This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Tokenize subclass list names in tree-sitter grammar #298
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
This PR tokenizes the names of subclasses listed within class definitions, for Python files matched by the tree-sitter grammar.
Before:

After:

Alternate Designs
I don't know if the Atom team desires to tokenize these subclass names differently; I figured
entity.other.inherited-class
was the most appropriate scope, as it's based on the same scope from the first-mate grammar.Benefits
Syntax highlighting that is more familiar to longtime users of the Python first-mate grammar.
Possible Drawbacks
Perhaps some might prefer different colors be used for the subclass names, though I personally like them.
Applicable Issues
N/A