This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Eliminating some extra string copies #27
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thanks for the @hokein's effort. The test has an excessive long line. Making this benchmark fast will result faster parsing for some real-world peculiar files.
OnigStringContext is an immutable object that encapsulates various forms of v8String states, including UTF8 copy, UTF16 copy and a predicate. OnigStringContext is reusable, and it can eliminate extra string copying if the same V8 string is given to FindNextMatchSync() in subsequent calls. Speedup: * large.js sync: 482ms -> 366ms * large.js async: 5914ms -> 4971ms (This number is noisy) * oneline sync: 66624ms -> 1085ms * oneline async: N/A (took to long) Although there are some rooms for improvement in async case, this overall seems good starting point to address slow-long-line problem.
|
Re-opened this as #28 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I'm trying to harvest some low hanging fruits for atom/atom#979
before we make big changes. What do you think?