Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Deactivate correctly #1027

Merged
merged 3 commits into from
Dec 11, 2017
Merged

Deactivate correctly #1027

merged 3 commits into from
Dec 11, 2017

Conversation

winstliu
Copy link
Contributor

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

Properly dispose of any disposables on deactivation to prevent lingering traces of Settings View from lying around.

Alternate Designs

None.

Benefits

Better package deactivation.

Possible Drawbacks

None.

Applicable Issues

This addresses #764 to the maximum extent possible without changing code in Atom core.

@winstliu winstliu merged commit f39fe44 into master Dec 11, 2017
@winstliu winstliu deleted the wl-deactivate-disposables branch December 11, 2017 23:34
@winstliu
Copy link
Contributor Author

winstliu commented Jan 3, 2018

It looks like this is causing the keyboard-scrollable spec to be very flaky, so I'm reverting this until I figure out the problem.

@winstliu winstliu restored the wl-deactivate-disposables branch January 3, 2018 17:09
@winstliu winstliu deleted the wl-deactivate-disposables branch January 3, 2018 17:09
@winstliu winstliu restored the wl-deactivate-disposables branch January 3, 2018 17:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant