Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allocate stack with best price #30

Merged
merged 3 commits into from
Nov 19, 2024
Merged

feat: allocate stack with best price #30

merged 3 commits into from
Nov 19, 2024

Conversation

Cifko
Copy link
Collaborator

@Cifko Cifko commented Nov 14, 2024

When no stacks are found for the given model. We find the best task with the node with the best price and allocate maximum number of tokens that the node allows us.

@Cifko Cifko requested a review from jorgeantonio21 November 14, 2024 11:46
Copy link
Contributor

@jorgeantonio21 jorgeantonio21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to pick the best node, based on price (other metrics in the future), amon the current available Stacks that are bound to a Task holding a specific model.

atoma-state/src/state_manager.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@jorgeantonio21 jorgeantonio21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

Left minor comments, that can be quickly addressed

atoma-state/src/handlers.rs Outdated Show resolved Hide resolved
atoma-state/src/state_manager.rs Show resolved Hide resolved
@jorgeantonio21 jorgeantonio21 merged commit be02541 into main Nov 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants