Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: track performance #32

Merged
merged 2 commits into from
Nov 18, 2024
Merged

feat: track performance #32

merged 2 commits into from
Nov 18, 2024

Conversation

Cifko
Copy link
Collaborator

@Cifko Cifko commented Nov 15, 2024

Track node performance

  • throughput, what was the time from request send to receiving result
  • latency (only for streaming) what was the time from the request send to first token to arrive

@Cifko Cifko requested a review from jorgeantonio21 November 15, 2024 12:34
jorgeantonio21
jorgeantonio21 reviewed Nov 16, 2024
View reviewed changes
Copy link
Contributor

@jorgeantonio21 jorgeantonio21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

let's tackle the comments above and we merge it.

atoma-state/src/state_manager.rs Show resolved Hide resolved
atoma-state/src/state_manager.rs Show resolved Hide resolved
atoma-proxy/src/server/chat_completions.rs Show resolved Hide resolved
atoma-proxy/src/server/chat_completions.rs Show resolved Hide resolved
atoma-proxy/src/server/chat_completions.rs Show resolved Hide resolved
atoma-proxy/src/server/chat_completions.rs Show resolved Hide resolved
atoma-proxy/src/server/chat_completions.rs Show resolved Hide resolved
atoma-proxy/src/server/chat_completions.rs Show resolved Hide resolved
@Cifko Cifko merged commit cd5c8d4 into main Nov 18, 2024
1 check passed
@Cifko Cifko mentioned this pull request Nov 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgeantonio21 jorgeantonio21 jorgeantonio21 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Cifko @jorgeantonio21