Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: check the signature on updating public address of the node #37

Merged
merged 4 commits into from
Dec 9, 2024
Merged

feat: check the signature on updating public address of the node #37

merged 4 commits into from
Dec 9, 2024

Conversation

Cifko
Copy link
Collaborator

@Cifko Cifko commented Nov 26, 2024

Check the signature when calling update public address for a node.

  • check if the signature is valid
  • check if the signature is for the same small id that's in the request

@Cifko Cifko requested a review from jorgeantonio21 November 26, 2024 17:22
@Cifko Cifko force-pushed the node-address-signature branch from fdf404e to ad836da Compare November 28, 2024 13:22
jorgeantonio21
jorgeantonio21 requested changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@jorgeantonio21 jorgeantonio21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, but some changes are required

atoma-proxy/src/server/http_server.rs Outdated Show resolved Hide resolved
atoma-proxy/src/server/http_server.rs Outdated Show resolved Hide resolved
atoma-proxy/src/server/http_server.rs Outdated Show resolved Hide resolved
atoma-state/src/state_manager.rs Show resolved Hide resolved
@Cifko Cifko force-pushed the node-address-signature branch from 40b2dc0 to 16ecc6f Compare December 5, 2024 09:33
jorgeantonio21
jorgeantonio21 reviewed Dec 5, 2024
View reviewed changes
Copy link
Contributor

@jorgeantonio21 jorgeantonio21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking better but still some changes are required.

I do believe we need a p2p network so that we don't need to call this method, as there might be 1000s of proxies and node operators can't possible register to all of them...

atoma-state/src/handlers.rs Show resolved Hide resolved
atoma-state/src/handlers.rs Show resolved Hide resolved
atoma-proxy/src/server/http_server.rs Outdated Show resolved Hide resolved
atoma-proxy/src/server/http_server.rs Show resolved Hide resolved
atoma-proxy/src/server/http_server.rs Outdated Show resolved Hide resolved
@Cifko
Copy link
Collaborator Author

Cifko commented Dec 6, 2024

Looking better but still some changes are required.

I do believe we need a p2p network so that we don't need to call this method, as there might be 1000s of proxies and node operators can't possible register to all of them...

I agree, but currently we can't deploy working network without this. And we don't have p2p implemented. So if we don't plant o hardcode the addresses into the proxy right now, we need this pr to go in.

jorgeantonio21
jorgeantonio21 approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@jorgeantonio21 jorgeantonio21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jorgeantonio21 jorgeantonio21 merged commit b0fd59f into main Dec 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgeantonio21 jorgeantonio21 jorgeantonio21 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Cifko @jorgeantonio21