Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Denarius (D) currency #597

Merged
merged 3 commits into from
Apr 17, 2019
Merged

Conversation

metaspartan
Copy link
Contributor

Adds back Denarius (D) Support to HyperDEX

PR for Cryptocurrency Icons to update namings from DNR to D:
spothq/cryptocurrency-icons#295

PR for jl777 coins repo, already merged:
jl777/coins#276

@sindresorhus
Copy link
Contributor

DNR electrums were run by the coin owner, but not maintained, so they were causing problems
- #577 (comment)

What guarantees do we have that this won't happen again?


Please also read and adhere to https://github.com/atomiclabs/hyperdex/blob/master/docs/add-currency.md (Read it thoroughly)

@metaspartan
Copy link
Contributor Author

DNR electrums were run by the coin owner, but not maintained, so they were causing problems

What guarantees do we have that this won't happen again?

Please also read and adhere to https://github.com/atomiclabs/hyperdex/blob/master/docs/add-currency.md (Read it thoroughly)

Two of the electrums are ran by a team mate now and I am running the third, they are hosted on a better platform now as well for all of them. We want Denarius on the HyperDEX, there was communication issues before due to you guys moving from Slack and myself leaving due to the Slack exploits. We are all on Discord now for easier communication.

@buzzkillb
Copy link

I will be running some of the servers, so its not just falling on carsen this time. They will be kept up.

@lukechilds
Copy link
Member

This looks good to me.

@sindresorhus is there anything you spot missing from https://github.com/atomiclabs/hyperdex/blob/master/docs/add-currency.md ?

@sindresorhus
Copy link
Contributor

The servers should available on **domains/subdomains, not IP addresses. **

@sindresorhus
Copy link
Contributor

The title of the pull request should be Add Name (SYMBOL) currency. For example, Add FooCoin (FOO) currency.

@lukechilds
Copy link
Member

@carsenk @buzzkillb whichever of you runs 51.158.98.28 can you put a domain in front of it?

Should help reduce downtime in the event that you need to change servers or for some other reason lose access to that IP.

@lukechilds lukechilds changed the title Add Denarius (D) support Add Denarius (D) currency Apr 14, 2019
@metaspartan
Copy link
Contributor Author

@lukechilds

I pointed denariuspool.info and electrum.denariuspool.info to 51.158.98.28

It will take awhile for DNS propogation

@metaspartan
Copy link
Contributor Author

metaspartan commented Apr 14, 2019

Also denarius.vip and electrum.denarius.vip will be pointed to 51.158.98.28 and eventually a forth server

@sindresorhus sindresorhus merged commit e589e08 into atomiclabs:master Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants