-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: continue BSP building workflow if build any BSP fails #745
CI: continue BSP building workflow if build any BSP fails #745
Conversation
d3877d0
to
73fb006
Compare
This is a step towards allowing the job to continue if any tier >1 BSPs fail to build.
Resolves a warning about Node deprecation
73fb006
to
cf4ef86
Compare
The required statuses come from the project's branch protection settings, they would need to be updated after this change is accepted in to master. The list of checks for Tier 1 BSPs would be replaced with a single check on "Tier 1 BSPs all built on stable". |
b75f83a
to
86a4855
Compare
I wouldn't say that a Tier 2 is necessarily expected to fail. As discussed on Matrix, Tier 2 BSPs are locked to a specific I don't know how much complexity this would add, but just a suggestion to get around this: Would it be feasible to only run CI on BSPs if:
|
Sorry, that was poor wording on my part, meant that in this specific PR the itsybitsy m0 is expected to fail.
As external issues arise, with this change we'll know about them but they won't interfere with work. To me, this seems a bit better than letting issues silently accumulate, or relying on users to report them. That said, I think that would be possible, and likely worth doing if we start running in to issues with time/cost of building all the BSPs. |
86a4855
to
b8ee766
Compare
) * CI: Use BSP objects instead of names in job matrix This is a step towards allowing the job to continue if any tier >1 BSPs fail to build. * CI: Continue if job fails for tier >1 BSP build * CI: Update to newer checkout action Resolves a warning about Node deprecation * CI: Add job to show Tier 1 BSPs built on stable
Summary
Potential fix for #744 - this change to CI has the "Build BSPs" workflow continue regardless of tier >1 BSP builds failing.
One downside to this approach is that the overall workflow run may show success despite there actually being BSP build failures. This PR is a test case to see how obvious this situation is in practice - a tier 2 BSP is expected to fail.