Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: functional test leaks #546

Merged
merged 16 commits into from
Feb 4, 2025
Merged

fix: functional test leaks #546

merged 16 commits into from
Feb 4, 2025

Conversation

XavierChanth
Copy link
Member

@XavierChanth XavierChanth commented Feb 4, 2025

- What I did

  • Enable functional tests

  • Remove the teardown from functional tests which delete the shared enc keys

    • Causes bad state on non-ve atSigns
    • We still test for the creation of new shared enc keys at least once every time we spin up a new ve
  • Fix all leaks in tests - except monitor

    • Monitor requires larger refactoring to ensure memory is cleaned up and all major edge-cases are testable, so I've disabled the test, with intention to rewrite new more comprehensive ones. It turns out my local had monitor tests which should fail, but they weren't failing.

- How I did it

- How to verify it

  • unit tests have an additional memcheck step
  • functional tests have a matrix for with/without memcheck

- Description for the changelog
fix: functional test leaks

@XavierChanth XavierChanth force-pushed the fix-func-leaks branch 11 times, most recently from 043380e to 542636a Compare February 4, 2025 15:13
@XavierChanth XavierChanth marked this pull request as ready for review February 4, 2025 15:33
@XavierChanth XavierChanth merged commit 74eead7 into trunk Feb 4, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants