Fix incorrect rendering of first item in report #630
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
atteneder
approved these changes
May 23, 2024
There was a problem hiding this comment.
I couldn't reproduce the mis-layout (I assume due to fixes in UI Toolkit), but it showed the report item quantity at the top:
What makes it really bad is you can remove items by editing the Size. Now it looks like that:
Will be included in an upcoming release.
Thanks for your contribution ❤️
|
I'll merge this internally...closing this PR. |
|
Released in 6.6.0 Again, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UIToolkit's ListView seems to be quite a mess. With 2022.3.2f1 I had trouble reading the report because the first item is cut off (and strangely not indented like other items). Here's a quick fix.
Before:
After:
Quickly tested with 2022.3.2f, 2021.3.27f, 2020.3.45f