Skip to content
This repository has been archived by the owner on Aug 28, 2021. It is now read-only.

Use a non-nil ValueReader in sequenceChunker.Done #2273

Merged
merged 3 commits into from
Aug 5, 2016
Merged

Use a non-nil ValueReader in sequenceChunker.Done #2273

merged 3 commits into from
Aug 5, 2016

Conversation

kalman
Copy link
Contributor

@kalman kalman commented Aug 4, 2016

Fixes #2220.

@kalman kalman assigned ghost Aug 4, 2016
@ghost
Copy link

ghost commented Aug 4, 2016

go lgtm. i can haz js?

@kalman
Copy link
Contributor Author

kalman commented Aug 4, 2016

oops. forgot. Yes.

Benjamin Kalman added 2 commits August 5, 2016 13:23
@kalman
Copy link
Contributor Author

kalman commented Aug 5, 2016

PTAL

@ghost
Copy link

ghost commented Aug 5, 2016

lgtm. thanks for doing this.

@kalman kalman merged commit e50f773 into attic-labs:master Aug 5, 2016
@kalman kalman deleted the seq-ni branch August 5, 2016 21:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

P-Tree mutatation operations must hand in ValueReader (if any) to sequenceChunker.Done()
1 participant
@kalman