-
Notifications
You must be signed in to change notification settings - Fork 35
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix issue with linters that prefer single quotes
Activity: /issues/12 I ran into [this issue](/issues/12) as well where linters (Sonarlint in my case) take exception to the double-quotes output. I've changed the template and test files to use single-quotes and am using .replace on the template.constant.value to replace double-quotes with single-quotes. Tests pass.
- Loading branch information
Adam Merrifield
committed
Sep 9, 2016
1 parent
b6e1c45
commit 17490cb
Showing
19 changed files
with
43 additions
and
43 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
angular.module("<%= moduleName %>"<% if (createModule) { %>, []<% } %>)<% _.forEach(constants, function (constant) { %> | ||
.<%= type %>("<%= constant.name %>", <%= constant.value %>)<% }); %>; | ||
angular.module('<%= moduleName %>'<% if (createModule) { %>, []<% } %>)<% _.forEach(constants, function (constant) { %> | ||
.<%= type %>('<%= constant.name %>', <%= constant.value %>)<% }); %>; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
angular.module("gulp-ng-config", []) | ||
.constant("one", "two"); | ||
angular.module('gulp-ng-config', []) | ||
.constant('one', 'two'); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
angular.module("gulp-ng-config", []) | ||
.constant("environmentA", {"one":{"two":"three"}}) | ||
.constant("environmentB", {"four":{"five":"six"}}); | ||
angular.module('gulp-ng-config', []) | ||
.constant('environmentA', {'one':{'two':'three'}}) | ||
.constant('environmentB', {'four':{'five':'six'}}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
angular.module("gulp-ng-config", []) | ||
.constant("one", {"two":"three"}) | ||
.constant("constant", "value"); | ||
angular.module('gulp-ng-config', []) | ||
.constant('one', {'two':'three'}) | ||
.constant('constant', 'value'); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
angular.module("gulp-ng-config", []) | ||
.constant("one", { | ||
"two": "three" | ||
angular.module('gulp-ng-config', []) | ||
.constant('one', { | ||
'two': 'three' | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
angular.module("gulp-ng-config", []) | ||
.constant("one", { | ||
"two": "three" | ||
angular.module('gulp-ng-config', []) | ||
.constant('one', { | ||
'two': 'three' | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
angular.module("gulp-ng-config", []) | ||
.constant("one", {"two":"three"}); | ||
angular.module('gulp-ng-config', []) | ||
.constant('one', {'two':'three'}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
angular.module("gulp-ng-config", []) | ||
.constant("one", {"two":"three"}); | ||
angular.module('gulp-ng-config', []) | ||
.constant('one', {'two':'three'}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
angular.module("gulp-ng-config", []) | ||
.value("one", {"two":"three"}); | ||
angular.module('gulp-ng-config', []) | ||
.value('one', {'two':'three'}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
import angular from 'angular'; | ||
export default angular.module("gulp-ng-config", []) | ||
.constant("one", {"two":"three"}); | ||
export default angular.module('gulp-ng-config', []) | ||
.constant('one', {'two':'three'}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
angular.module("gulp-ng-config", []) | ||
.constant("one", {"two":"three"}); | ||
angular.module('gulp-ng-config', []) | ||
.constant('one', {'two':'three'}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
angular.module("gulp-ng-config", []) | ||
.constant("one", {"two":"four"}); | ||
angular.module('gulp-ng-config', []) | ||
.constant('one', {'two':'four'}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
angular.module("gulp-ng-config", []) | ||
.constant("one", {"two":"three","three":"four"}); | ||
angular.module('gulp-ng-config', []) | ||
.constant('one', {'two':'three','three':'four'}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
angular.module("gulp-ng-config") | ||
.constant("one", {"two":"three"}); | ||
angular.module('gulp-ng-config') | ||
.constant('one', {'two':'three'}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
(function () { | ||
return angular.module("gulp-ng-config", []) | ||
.constant("one", {"two":"three"}); | ||
(function () { | ||
return angular.module('gulp-ng-config', []) | ||
.constant('one', {'two':'three'}); | ||
|
||
})(); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
define(['angular', function () { | ||
return angular.module("gulp-ng-config", []) | ||
.constant("one", {"two":"three"}); | ||
return angular.module('gulp-ng-config', []) | ||
.constant('one', {'two':'three'}); | ||
}]); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
angular.module("gulp-ng-config", []) | ||
.constant("one", {"two":"three"}); | ||
angular.module('gulp-ng-config', []) | ||
.constant('one', {'two':'three'}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
angular.module("gulp-ng-config", []) | ||
.constant("four", {"five":"six"}); | ||
angular.module('gulp-ng-config', []) | ||
.constant('four', {'five':'six'}); |