Lower gc pressure #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doits
force-pushed
the
lower_gc_pressure
branch
2 times, most recently
from
9ca6c64 to
1170535
Compare
|
By using prepend we have no duplicated code, but it requires Ruby >= 2. Are you OK to drop Ruby < 2 support? |
Not sure why `reject` gives warnings, `select` not ...
By using the `missing_interpolation_argument_handler` and not always merging the globals with local interpolation values, it does not create a new hash for each call anymore. Lowers GC pressure noticable.
Because: No copy and pasted code from I18n
doits
force-pushed
the
lower_gc_pressure
branch
from
fd9ea85 to
ab99bfd
Compare
doits
force-pushed
the
lower_gc_pressure
branch
from
ab99bfd to
a8b8472
Compare
|
Well, Ruby 2 is not supported anymore anyway, so I think it's fine. I'll make a point about it in the Readme though. |
|
Alright, great. |
thabemmz
added a commit
to Mobiliteitsfabriek/i18n-globals
that referenced
this pull request
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using the
missing_interpolation_argument_handlerand not always merging the globals with local interpolation values, it does not create a new hash for each call anymore. Lowers GC pressure noticeable.This adds some complexity in favour of performance ... what do you say @attilahorvath?
Created on top of #5 and #7, so when they are merged, this is cleaner.