Parse all OscMessages available within a packet's datagram #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A datagram can contain multiple OscMessages. This patch adds a field to an OscMessage containing the remaining (tail) bytes of its datagram. The OscPacket constructor continues to parse OscMessages from a datagram until all bytes are consumed.
attwad
reviewed
Sep 25, 2024
| self._messages.append(TimedMessage(now, msg)) | ||
| if msg._dgram_tail is None: | ||
| break | ||
| dgram = msg._dgram_tail |
There was a problem hiding this comment.
please provide a readonly property instead of accessing the _dram_tail from another class
| while(True): | ||
| msg = osc_message.OscMessage(dgram) | ||
| self._messages.append(TimedMessage(now, msg)) | ||
| if msg._dgram_tail is None: |
There was a problem hiding this comment.
nit. you can just use if not msg.dgram_tail:, no need to compare against None
| @@ -68,7 +68,14 @@ def __init__(self, dgram: bytes) -> None: | |||
| key=lambda x: x.time, | |||
| ) | |||
| elif osc_message.OscMessage.dgram_is_message(dgram): | |||
| self._messages = [TimedMessage(now, osc_message.OscMessage(dgram))] | |||
| self._messages = [] | |||
| while(True): | |||
There was a problem hiding this comment.
nit. just while True: without parenthesis
| @@ -68,7 +68,14 @@ def __init__(self, dgram: bytes) -> None: | |||
| key=lambda x: x.time, | |||
| ) | |||
| elif osc_message.OscMessage.dgram_is_message(dgram): | |||
| self._messages = [TimedMessage(now, osc_message.OscMessage(dgram))] | |||
| self._messages = [] | |||
| while(True): | |||
There was a problem hiding this comment.
you could also base the condition of that while loop on the presence of the msg.dgram_tail, it'd read better, something like:
while msg.dgram_tail:
msg = osc_message.OscMessage(dram)
self._messages.append(TimedMessage(now, msg)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A datagram can contain multiple OscMessages. This patch adds a field to an OscMessage containing the remaining (tail) bytes of its datagram. The OscPacket constructor continues to parse OscMessages from a datagram until all bytes are consumed.