Prefer PWD environment variable over cwd if available to better support symbolic links

[pdecat]

This PR uses the PWD environment variable if it is available instead of calling env::current_dir().

Motivation: I was short on storage space in my main /home/user filesystem, so I moved all my /home/user/workspaces to another disk at /home/newdisk/user/workspaces, then created a symbolic link from /home/user/workspaces to /home/newdisk/user/workspaces.
To my dismay, when I searched my command history with the directory filter mode, nothing showed up.

For reference:

• Document canonicalization in std::env::current_dir rust-lang/rust#93598 (comment)
• https://stackoverflow.com/a/71625035/316805

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
atuin	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Mar 14, 2023 at 4:12PM (UTC)

[pdecat]

I do not believe this comment is worth keeping as utils::get_current_dir() returns an empty string if all else fails.

[conradludgate]

Hmmm. Just so I'm clear PWD would produce /home/user/workspaces but cwd() would follow the symlink to /home/newdisk/user/workspaces?

[pdecat]

Yes, precisely.

[ellie]

Definitely reasonable behaviour, and I think the user is more likely to want this

Could consider making it configurable in the future

Thank you!

[pdecat]

Just figured it may cause troubles for users already having commands in their history executed from symlinked folders (it was the case for one of mines).

Maybe this behavior should be made be opt-in with a configuration option?

An alternative would be to allow mass updating commands, but I guess its the same trouble as for deleting records, maybe even harder.