Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing Travis build #394

Merged
merged 5 commits into from
Feb 7, 2018
Merged

Fix failing Travis build #394

merged 5 commits into from
Feb 7, 2018

Conversation

ErwinJanssen
Copy link
Contributor

The Travis build of projects generated with this cookiecutter fail out of the box. The Travis build for the project itself is also failing. This pull request attempts to resolve this by:

  • Updating the test setup of the project to match the setup of the generated project. The generated project seems to have a more modern approach, and keeping this uniform will improve maintainability.
  • Update all dependencies to the most recent versions.
  • Remove support for Python 2.6 (no longer supported by the Python core team) and Python 3.3 (not supported by Pytest)

Additionally, support for Python 3.6 was added, since this is the most recent version.

The root cookiecutter project has a different configuration for both tox
and Travis, compared to the generated project. This is inconsistant, but
also makes it difficult to detect breakage of the test setup of the
generated project. Updating the setups to match increases
maintainability.
Python 2.6 is no longer supported by the Python core team. Most tools no
longer support this version of Python, pip will also drop Python 2.6
support in a future release. Therefore this version of Python should not
be included in the generated project.
Recent releases of Pytest no longer support Python 3.3. This means that
a generated project using a recent version of Pytest will fail it's test
cases. Because the generated project should work out-of-the-box, support
for Python version 3.3 is removed.
Python 3.6 is the most recent stable release of Python (2016-12-23), so
code should be tested against this version.
@hugovk
Copy link
Contributor

hugovk commented Jan 17, 2018

👍

Remove support for Python 2.6 (no longer supported by the Python core team) and Python 3.3 (not supported by Pytest)

Yep, both Python 2.6 and 3.3 are no longer supported by the Python core team nor Pytest.


Here's the pip installs for cookiecutter from PyPI for last month, showing virtually nothing for 2.6 and 3.3:

python_version percent download_count
3.6 73.4% 77,025
2.7 24.3% 25,548
3.5 1.7% 1,759
3.4 0.5% 498
3.7 0.1% 76
3.3 0.0% 15
2.6 0.0% 8

Source: pypinfo --start-date -47 --end-date -17 --percent --pip --markdown cookiecutter pyversion


You could also update this to (3, 4) in test_bake_project.py:

    elif sys.version_info >= (3, 3):

(Then when 3.4 is ditched, the whole elif block can be removed.)

@hugovk hugovk mentioned this pull request Jan 17, 2018
@pydanny pydanny merged commit 8e59629 into audreyfeldroy:master Feb 7, 2018
@ErwinJanssen ErwinJanssen deleted the fix-travis branch February 19, 2018 09:10
juneqch pushed a commit to profilech/.cookiecutter-pypackage that referenced this pull request Jun 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants