fix clippy lint errors with latest cargo #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
future-highway
approved these changes
Nov 17, 2023
There was a problem hiding this comment.
Didn't do a local build, but LGTM.
From my understanding, resolver = "2" is the default since we are only using edition 2021, but I assume you had a reason to add it explicitly.
Edit: Just realized I put resolver = "2" in my own project too (can't remember why).
it was a cargo warning about a mismatch between the default (1) and the default for 2021 (2). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updating the dependencies seems to help with the newer clippy lint errors.