-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(auraescript): Upgrade Deno #513
Conversation
ccc5b33
to
d550fb8
Compare
Seems like this breaks
|
d550fb8
to
254b5cd
Compare
Seems to be working well! A few errors that seem to be more like bugs in
|
interesting. do we see this before the upgrade? |
After a restart these "no process found" or "cgroup exists" errors are gone (both on main and this branch). The problem seemed to be stale cgroups on my machine from prior tests not being cleaned up 👍 |
so is this ready to merge? |
let path = module_specifier | ||
.to_file_path() | ||
.map_err(|_| anyhow!("Only file: URLs are supported."))?; | ||
.map_err(|_| anyhow!("Only file:// URLs are supported."))?; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we use the requested module type instead of extracting it from the path? or maybe use the requested module path and the path-derived version of None is passed in?
Fixes some build errors due to dependency conflicts by upgrading Deno libraries. We also split
deno_runtime
anddeno_core
again to allow for macros to work properly (re-exporteddeno_core
could not be found).Also disables the snake case clippy lint for auraescript modules as it now fails on the
as__
prefixed functions generated by our macros.