fix(webpack): fix broken karma tests in webpack v4 #998
Conversation
Fixes error: "Module not found: Error: Can't resolve 'fs' in" Fixes issue where tests dont run in webpack v4 Fixes: aurelia#996
| @@ -43,6 +43,7 @@ module.exports = ({ production, server, extractCss, coverage, analyze, karma } = | |||
| // out-of-date dependencies on 3rd party aurelia plugins | |||
| alias: { 'aurelia-binding': path.resolve(__dirname, 'node_modules/aurelia-binding') } | |||
| }, | |||
| node: { fs: 'empty' }, // Fixes issue: "Error: Can't resolve 'fs'" when running karma tests | |||
There was a problem hiding this comment.
In normal run, webpack stubs nodejs core module like fs. What's the issue with our webpack+karma setup?
Maybe we should fix our karma.conf.js instead of webpack.config? Because fs is not the only nodejs core module, if you fix the issue here, you need lot more than just fs: 'empty'.
There was a problem hiding this comment.
Sorry I don't know much about the karma config, feel free to modify the PR for the best solution.
There was a problem hiding this comment.
I am no master of karma either. I just don’t understand the nature of this recent webpack karma issue.
Personally I try to avoid both webpack and karma as much as possible :)
|
With revert of #970, this is not needed anymore. |
Fixes error: "Module not found: Error: Can't resolve 'fs' in"
Fixes issue where tests dont run in webpack v4
Fixes: #996