-
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSS Reset #124
Comments
@EisenbergEffect I am going to pick this one up, it should be quick. Is there a particular CSS reset we have our eye on using or are we going to roll our own? |
I dropped one in the showcase app that worked well. Can we pull it out of there and embed it into the ux core? |
Yep, sure thing. |
Good idea. Just dropping some infos here as it might be useful / interesting. I've made some tests using a combination of Aurelia UX and Bootstrap 4. I'm currently doing this with the use of a custom plugin that parse bootstrap SCSS (with a set of custom SCSS variables for the project) and merge the bootstrap config variables into Aurelia UX JS variables (with an Aurelia CLI custom task). Basically the primary bootstrap color is parsed from the SCSS and imported as JS variable into AureliaUX instance (secondary becomes accent, and the light and dark values are computed using lighten and darken mixins from bootstrap). With this system I can pick and choose what part of bootstrap / aurelia UX I use in my projects. For exemple, I use lots of cards and list-group + the grid from bootstrap and nearly everything from aurelia ux (inputs, buttons, icons, ...). Why dropping this here ? Because I was wondering if adding the CSS reset in the Core of Aurelia UX could cause any incompatibilities with Bootstrap 4 and if yes, how to avoid this ? |
I think there should be a method on the UX config object that applies the reset. It should be called as part of the default configuration, but for advanced scenarios like merging with bootstrap, it should be possible to do a manual config and not apply the reset. |
Adds reset css code to the header of the document when aurelia-ux is started. This can be disabled in the configuration. resovles aurelia#124
CSS Reset for Aurelia UX to enable consistent rendering across browsers.
The text was updated successfully, but these errors were encountered: