-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added optional paramaters to login API #199
Conversation
Out of interest, what parameters are you sending? |
@cocojoe Thanks for reviewing this, I'm passing custom params to a rule. The app I'm working on is internal and requires device whitelisting. I've fixed the code style but I'm not sure why the tests are failing now... |
Alight, fixed the tests, turns out I forgot to update the protocol extension. |
Thanks, will review soon. |
@akiroz looks good, please add some tests, so we know that parameters are being passed etc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general, add actual tests for testing parameters
@cocojoe Test added! |
Would love to see this merged in! I am using the Lock library for login, but Auth0 login for our test cases. |
Sorry for delay, was on Holiday. |
Added
parameters
to the new/oauth/token
API since the old/oauth/ro
API is deprecated.