Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added optional paramaters to login API #199

Merged
merged 5 commits into from
Jun 4, 2018
Merged

Conversation

akiroz
Copy link
Contributor

@akiroz akiroz commented May 16, 2018

Added parameters to the new /oauth/token API since the old /oauth/ro API is deprecated.

@cocojoe
Copy link
Member

cocojoe commented May 16, 2018

Out of interest, what parameters are you sending?
Also to pass CI you need to fix your formatting, https://circleci.com/gh/auth0/Auth0.swift/438?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

@akiroz
Copy link
Contributor Author

akiroz commented May 16, 2018

@cocojoe Thanks for reviewing this, I'm passing custom params to a rule. The app I'm working on is internal and requires device whitelisting.

I've fixed the code style but I'm not sure why the tests are failing now...

@akiroz
Copy link
Contributor Author

akiroz commented May 16, 2018

Alight, fixed the tests, turns out I forgot to update the protocol extension.

@cocojoe
Copy link
Member

cocojoe commented May 17, 2018

Thanks, will review soon.

@cocojoe cocojoe self-requested a review May 17, 2018 12:29
@cocojoe
Copy link
Member

cocojoe commented May 22, 2018

@akiroz looks good, please add some tests, so we know that parameters are being passed etc

Copy link
Member

@cocojoe cocojoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general, add actual tests for testing parameters

@akiroz
Copy link
Contributor Author

akiroz commented May 22, 2018

@cocojoe Test added!

@dylanmoo
Copy link

dylanmoo commented Jun 4, 2018

Would love to see this merged in! I am using the Lock library for login, but Auth0 login for our test cases.

@cocojoe
Copy link
Member

cocojoe commented Jun 4, 2018

Sorry for delay, was on Holiday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants