Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CustomTextField & sign up form should support fields without icons #409

Closed
ened opened this issue Mar 3, 2017 · 5 comments
Closed

CustomTextField & sign up form should support fields without icons #409

ened opened this issue Mar 3, 2017 · 5 comments
Labels
enhancement An enhancement or improvement to the SDK that could not be otherwise categorized as a new feature
Milestone

Comments

@ened
Copy link

ened commented Mar 3, 2017

As written in the subject, we would like to remove the images from our custom fields:

$0.customSignupFields = [
    CustomTextField(name: "given_name", placeholder: "First Name", icon: LazyImage(name: "974-users"), validation: handleGivenName),
    CustomTextField(name: "family_nane", placeholder: "Last Name", icon: LazyImage(name: "974-users"), validation: handleFamilyName)
]

=> The icon field should become optional.

@cocojoe
Copy link
Member

cocojoe commented Mar 3, 2017

Hi @ened

I feel this would not be in keeping with the primary fields such as email and password, you could use a transparent image although again this gives you an inconsistent look and feel

@ened
Copy link
Author

ened commented Mar 3, 2017

@cocojoe Get your reasoning, yet still two comments:

  1. Auth0's web-version allows me to remove the icons. It looks just fine.
  2. Any icon recommendation for first & last name? :-)

screen shot 2017-03-03 at 20 08 49

@cocojoe
Copy link
Member

cocojoe commented Mar 3, 2017

  1. That's a valid point, let me discuss internally.
  2. Personally I would go generic with a head type icon perhaps.

@hzalaz
Copy link
Member

hzalaz commented Mar 16, 2017

@ened we can add this to our backlog

@hzalaz hzalaz added the enhancement An enhancement or improvement to the SDK that could not be otherwise categorized as a new feature label Mar 16, 2017
cocojoe added a commit that referenced this issue Apr 21, 2017
Allow CustomTextField with no icon #409
cocojoe added a commit that referenced this issue Apr 26, 2017
Allow CustomTextField with no icon #409
cocojoe added a commit that referenced this issue Apr 28, 2017
Allow CustomTextField with no icon #409
cocojoe added a commit that referenced this issue May 8, 2017
Allow CustomTextField with no icon #409
@cocojoe
Copy link
Member

cocojoe commented May 16, 2017

Has been merged.

@cocojoe cocojoe closed this as completed May 16, 2017
@cocojoe cocojoe added this to the 2.3.0 milestone Jun 5, 2017
@cocojoe cocojoe mentioned this issue Jun 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or improvement to the SDK that could not be otherwise categorized as a new feature
Projects
None yet
Development

No branches or pull requests

3 participants