Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility updates against latest Auth0.Swift #356

Merged
merged 5 commits into from
Dec 16, 2016
Merged

Conversation

cocojoe
Copy link
Member

@cocojoe cocojoe commented Dec 15, 2016

Readme Updated
Add JWTDecode Lib
Ensure mocks conform to latest protocols

@cocojoe cocojoe changed the title Fixes pre release Fixes pre release (Wait for Auth0.Swift Release) Dec 15, 2016
@cocojoe
Copy link
Member Author

cocojoe commented Dec 15, 2016

This was built against HEAD of master Auth0.Swift, best to release 1.1 of that first and then I can update this PR.

@cocojoe cocojoe changed the title Fixes pre release (Wait for Auth0.Swift Release) Fixes for new release Dec 16, 2016
Copy link
Member

@hzalaz hzalaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also let's think of a better title for the PR

@@ -676,6 +677,7 @@
5FEAE2111D1A5716005C0028 /* Frameworks */ = {
isa = PBXGroup;
children = (
5B15CB241E02CEC100738FFC /* JWTDecode.framework */,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auth0.swift does not require it anymore so I think we should not do the same in Lock

Readme Updated
Add JWTDecode Lib
Ensure mocks conform to latest protocols
@cocojoe cocojoe changed the title Fixes for new release Compatibility updates against latest Auth0.Swift Dec 16, 2016
Remove all references to JWTDecode
@hzalaz hzalaz added this to the 2.0.0-rc.1 milestone Dec 16, 2016
@hzalaz hzalaz merged commit f640b12 into v2 Dec 16, 2016
@hzalaz hzalaz deleted the fixes_pre_release branch December 16, 2016 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants