Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n strings file for Base language in Lock #393

Merged
merged 6 commits into from
Feb 15, 2017
Merged

i18n strings file for Base language in Lock #393

merged 6 commits into from
Feb 15, 2017

Conversation

hzalaz
Copy link
Member

@hzalaz hzalaz commented Feb 15, 2017

  • Normalized key format
  • Use positional format arguments when needed
  • Put casing style in strings file instead of code (easier customization)
  • Include Base.lproj in Lock.framework

@hzalaz hzalaz added this to the v2-Next milestone Feb 15, 2017
@hzalaz hzalaz merged commit 450195a into v2 Feb 15, 2017
@hzalaz hzalaz deleted the changed-i18n-keys branch February 15, 2017 20:52
@hzalaz hzalaz modified the milestones: v2-Next, 2.0.0 Feb 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CH: Changed
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
1 participant
@hzalaz