Added Error message on database user creation if user already exists #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cocojoe
requested changes
Jul 5, 2017
Lock/DatabaseInteractor.swift
Outdated
| @@ -153,6 +153,9 @@ struct DatabaseInteractor: DatabaseAuthenticatable, DatabaseUserCreator, Loggabl | |||
| case .failure(let cause as AuthenticationError) where cause.code == "invalid_password": | |||
| callback(.passwordInvalid, nil) | |||
| self.dispatcher.dispatch(result: .error(DatabaseUserCreatorError.passwordInvalid)) | |||
| case .failure(let cause as AuthenticationError) where cause.code == "user_exists": | |||
Lock/DatabaseUserCreatorError.swift
Outdated
| @@ -30,6 +30,7 @@ enum DatabaseUserCreatorError: Error, LocalizableError { | |||
| case passwordHasUserInfo | |||
| case passwordInvalid | |||
| case passwordAlreadyUsed | |||
| case userExists | |||
Lock/DatabaseUserCreatorError.swift
Outdated
| @@ -43,6 +44,8 @@ enum DatabaseUserCreatorError: Error, LocalizableError { | |||
| return "PASSWORD HAS PREVIOUSLY BEEN USED.".i18n(key: "com.auth0.lock.error.signup.password_history", comment: "password_history") | |||
| case .passwordInvalid: | |||
| return "PASSWORD IS INVALID.".i18n(key: "com.auth0.lock.error.signup.invalid_password", comment: "invalid_password") | |||
| case .userExists: | |||
Lock/Base.lproj/Lock.strings
Outdated
| @@ -76,6 +76,8 @@ | |||
| "com.auth0.lock.error.recoverable.title" = "Can't load the login box"; | |||
| // Generic sign up error | |||
| "com.auth0.lock.error.signup.fallback" = "WE'RE SORRY, SOMETHING WENT WRONG WHEN ATTEMPTING TO SIGN UP."; | |||
| // user exists | |||
| "com.auth0.lock.error.signup.user_exists" = "THE USER ALREADY EXISTS."; | |||
There was a problem hiding this comment.
the way to update this file is by running bundle exec fastlane ios i18n in the Lock directory. It will auto generate the strings file after parsing the source code.
|
@f2m2rd also please add a test 😄 |
cocojoe
reviewed
Jul 6, 2017
| @@ -59,7 +59,11 @@ class DatabaseUserCreatorErrorSpec: QuickSpec { | |||
| let error = DatabaseUserCreatorError.nonValidInput | |||
| expect(error.localizableMessage).to(contain("SOMETHING WENT WRONG")) | |||
| } | |||
|
|
|||
|
|
|||
| it(".userExists should return relevant string") { | |||
There was a problem hiding this comment.
Thanks, just update formatting, for reference we use Xcode defaults.
- Indention
cocojoe
changed the title
cocojoe
approved these changes
Jul 6, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.