Added Swift 3.2/4.0 Compatibility #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbalmaceda
reviewed
Dec 26, 2017
| @@ -27,7 +27,7 @@ struct ObserverStore: Dispatcher { | |||
| var onAuth: (Credentials) -> Void = { _ in } | |||
| var onFailure: (Error) -> Void = { _ in } | |||
| var onCancel: () -> Void = { } | |||
| var onSignUp: (String, [String: Any]) -> Void = { _ in } | |||
| var onSignUp: (String, [String: Any]) -> Void = { _, _ in } | |||
There was a problem hiding this comment.
The is a callback event when a Sign up is successful. The syntax changed here, previously you could just use _ as a convenience to skip multiple parameters. Now you have to be explicit.
|
@lbalmaceda We should discuss Public API changes. |
|
@cocojoe I don't see them. Can you please point them? |
Update README Update Gems Update Circle CI Xcode 9.2
lbalmaceda
approved these changes
Jan 3, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are non breaking API changes, Swift-4 you may not have a public methods that references non public defaults in it's parameters.
For example this init that uses a0_orange as a default
https://github.com/auth0/Lock.swift/blob/swift-4/Lock/AuthStyle.swift#L55
So the simple change is to make this extension Public
https://github.com/auth0/Lock.swift/pull/480/files#diff-f498ad2e7d4a9faf01c3c4c0eed33b2aR25
https://github.com/auth0/Lock.swift/pull/480/files#diff-53d32afb8adea758803b9861a8937454R50
https://github.com/auth0/Lock.swift/pull/480/files#diff-4192270a149488807ff9d8c418f13e01R25
https://github.com/auth0/Lock.swift/pull/480/files#diff-f5620bd226b47bb12e0e2bc0fa045130R124