Support iOS 11 safe area layout guides #498
Conversation
- Guides supported on database only and database forgot password views
|
Can you provide some comparison screenshots please. |
|
Attached below. In current release, icon is too close to the notch (more noticeable when you have an icon without a flat edge on the top), and bottom 'Log In' button has overlap with home indicator.
|
|
thanks, I'll check it out as want to see how it looks across all the screens. I have a script that does this, let me run this and I'll post a link to the screenshots. |
|
@cocojoe Okay, sounds good, thanks! |
- Increase overall header view height
|
Great, just waiting on merging in #500 then we can run UI Tests to compare your changes against current in lots of different situations 👍 |
|
@cocojoe What's the status on getting this fix merged in? |
|
I wanted to run some more thorough screen comparisons but been caught up in other work, let me see if I can start doing that just now. @kevinwo can you rebase please |
|
Here are screenshots using master: (dont worry about missing iPhone 8 ones) |
|
This PR screenshots |
|
@cocojoe this should be reviewed by our design team first. |
|
Lack of activity |
I've added safe area layout guide support on database only and database forgot password views to improve the UI display on iPhone X. If my changes are deemed acceptable, I can make additional changes for the enterprise views. Thanks for taking the time to take a look, and please let me know if you have any questions!