Added support for Swift 4.2 #529
Conversation
|
Thanks for the PR, the demo app I can kind of live with as it's not part of the library. The UI tests are really just for me as they are used for generating screenshots for comparing Ux changes and comparison across devices. However, unit tests should run. Ideally I would like to run CI to test in both 3.x and 4.x although the former will be phased out soon. #510 was already fixed if you read through all the comments, was actually a kind of interesting issue related to swift compiler. |
|
I only linked #510 because it mentioned Swift 4.2, didn't realise it was because of that Swift compiler bug. |
|
Great, I'll take a look a the PR in a bit 👍 |
|
@cocojoe I think I've managed to get it all working. Let's see how Circle goes... |
Lock.xcodeproj/project.xcworkspace/xcshareddata/IDEWorkspaceChecks.plist
Outdated
Show resolved
Hide resolved
|
If you didn't already know it's https://auth0.com/blog/celebrate-hacktoberfest-with-auth0/ |
cocojoe
changed the title
@guykogus can you fill out this form and we'll sort this out! =) https://docs.google.com/forms/d/e/1FAIpQLSeEExVU_OPWhedfWdq3xD0gyrq1uo8_TUwH45JMlDKR7z1WEg/viewform |
|
@guykogus Good job on the changes 👍 |
Lock/Extensions.swift
Outdated
| static let responderKeyboardWillShowNotification = NSNotification.Name.UIKeyboardWillShow | ||
| static let responderKeyboardWillHideNotification = NSNotification.Name.UIKeyboardWillHide | ||
| static let responderKeyboardFrameEndUserInfoKey = UIKeyboardFrameEndUserInfoKey | ||
| static let responderKeyboardAnimationDurationUserInfoKey = UIKeyboardAnimationDurationUserInfoKey // swiftlint:disable:this identifier_name |
There was a problem hiding this comment.
@guykogus Are you using the latest SwiftLint v0.27? just a couple of warnings regarding superfluous_disable_command so can remove the SwiftLint exceptions for both lines 113 an 114
There was a problem hiding this comment.
They're only superfluous because of the version of Swift with which you're building because of the #if(swift...). I know how to solve this problem.
There was a problem hiding this comment.
Great, better than multiple statements.
|
@guykogus Thanks again for PR ✅ |
| @@ -1135,7 +1135,7 @@ | |||
| ); | |||
| runOnlyForDeploymentPostprocessing = 0; | |||
| shellPath = /bin/sh; | |||
| shellScript = "AUTH0_PLIST=\"${SRCROOT}/Auth0.plist\"\nif [ -f $AUTH0_PLIST ];\nthen\ncp \"$AUTH0_PLIST\" \"${BUILT_PRODUCTS_DIR}/${PRODUCT_NAME}.app\"\nfi"; | |||
| shellScript = "AUTH0_PLIST=\"${SRCROOT}/Auth0.plist\"\nif [ -f \"$AUTH0_PLIST\" ];\nthen\ncp \"$AUTH0_PLIST\" \"${BUILT_PRODUCTS_DIR}/${PRODUCT_NAME}.app\"\nfi\n"; | |||
There was a problem hiding this comment.
I forgot about this, why was this an issue for you? I do not have a problem here.
There was a problem hiding this comment.
This script fails if the file path has a space. That's why you always need quotes around it.
Changes
The code of the library, demo app and tests are designed to be backwards compatible with older versions of Xcode and Swift.
References
Testing
No changes to code logic or testing, so nothing new to add.
Checklist