Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expanded username validation characters #560

Merged
merged 3 commits into from
Jul 23, 2019
Merged

Expanded username validation characters #560

merged 3 commits into from
Jul 23, 2019

Conversation

cocojoe
Copy link
Member

@cocojoe cocojoe commented Jul 22, 2019

Changes

Added support for additional characters in username validation.

References

As defined in https://auth0.com/docs/connections/database/require-username

Checklist

@cocojoe cocojoe requested a review from a team July 22, 2019 09:23
@cocojoe cocojoe added this to the vNext milestone Jul 22, 2019
@cocojoe cocojoe added the small label Jul 22, 2019
@cocojoe cocojoe force-pushed the update-username-validation branch from 754ff62 to 9303cb3 Compare July 22, 2019 10:34
damieng
damieng reviewed Jul 22, 2019
View reviewed changes
damieng
damieng suggested changes Jul 22, 2019
View reviewed changes
Copy link
Contributor

@damieng damieng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add + to list of accepted chars.

@cocojoe cocojoe merged commit a7e3a11 into master Jul 23, 2019
@cocojoe cocojoe deleted the update-username-validation branch July 23, 2019 09:15
@cocojoe cocojoe mentioned this pull request Jul 26, 2019
Merged
@joshcanhelp joshcanhelp added review:small Small review and removed small labels Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damieng damieng damieng approved these changes

Assignees
No one assigned
Labels
CH: Added review:small Small review
Projects
None yet
Milestone
2.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@cocojoe @damieng @joshcanhelp