Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LockViewController scrolling #571

Merged
merged 1 commit into from
Sep 17, 2019
Merged

Conversation

ejensen
Copy link
Contributor

@ejensen ejensen commented Sep 12, 2019

Changes

Fixes scrolling within the LockViewController by adding Autolayout constraints that properly constrain the scrollview's content size.

Before & After
before after

References

Testing

Tested on both iPhone and iPad simulators. iPhone recordings shown above

  • This change has been tested on the latest version of the platform/language or why not

Checklist

@ejensen ejensen requested a review from a team September 12, 2019 21:21
@ejensen
Copy link
Contributor Author

ejensen commented Sep 12, 2019

ci/circleci: build-and-test-swift-5.1 failure seems unrelated to the changes in this PR:

Exit status of command 'carthage bootstrap --no-use-binaries --platform iOS --cache-builds' was 1 instead of 0.
Task failed with exit code 65:
usr/bin/xcrun xcodebuild -workspace /Users/distiller/project/Carthage/Checkouts/Quick/Quick.xcworkspace

@cocojoe
Copy link
Member

cocojoe commented Sep 16, 2019

Thanks for the contribution @ejensen. Looks good, have you manually tested across other devices and not just iPhone X?
Let me look into CI.

@ejensen
Copy link
Contributor Author

ejensen commented Sep 16, 2019

@cocojoe Yes I verified the layout on iPhone SE, iPhone 6, iPhone 6 Plus, iPhone X, iPhone XR and iPhone XS Max.

@cocojoe
Copy link
Member

cocojoe commented Sep 17, 2019

I've had a change to review this by hand. Looks good.

Copy link
Member

@cocojoe cocojoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have tested manually

@cocojoe cocojoe added this to the vNext milestone Sep 17, 2019
@cocojoe cocojoe merged commit 86bdc09 into auth0:master Sep 17, 2019
@ejensen ejensen deleted the scrollview-fix branch September 23, 2019 22:02
@cocojoe cocojoe mentioned this pull request Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants