Deprecated Legacy 1Password Manager Functionality #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevehobbsdev
approved these changes
Sep 18, 2019
Co-Authored-By: Steve Hobbs <[email protected]>
|
@damieng can you review the changes from the customer perspective please. Interested in your thoughts as it does impact the Public API. Thanks |
cocojoe
changed the title
|
As discussed in Zoom - but adding here for historical/record keeping - we should remove the functionality but leave enough code in that existing apps continue to compile/work ideally with a compiler warning. Then remove the actual stub in the next major to ensure no breaking changes. |
Restore OnePassword Class, now a dummy class, removed from codecov
cocojoe
changed the title
|
@damieng please re-review |
joshcanhelp
reviewed
Sep 24, 2019
| @@ -96,7 +93,7 @@ class DatabasePresenter: Presentable, Loggable { | |||
| self.messagePresenter?.hideCurrent() | |||
| let authCollectionView = self.authPresenter?.newViewToEmbed(withInsets: UIEdgeInsets(top: 0, left: 20, bottom: 0, right: 20), isLogin: true) | |||
| let style = self.database.requiresUsername ? self.options.usernameStyle : [.Email] | |||
| view.showLogin(withIdentifierStyle: style, identifier: identifier, authCollectionView: authCollectionView, showPassswordManager: self.passwordManager.available, showPassword: self.options.allowShowPassword) | |||
joshcanhelp
approved these changes
Sep 24, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Legacy OnePassword support has been removed, due to use of deprecated methods that are resulting in Apple Developer submission errors for iOS 13.
Password Manager support was added in iOS 12 at the OS level. So the previous functionality has been superseded and there are no updates on the original 1Password extension repo to address.
The options are now dummy options and will show a deprecation warning:
References
#568
https://community.auth0.com/t/lock-v2-ios-deprecated-api-usage-uiwebview-apis/30563
Testing
N/A
Checklist