Fix iOS 13.x Bug - Calling UI on non-main thread #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cocojoe
changed the title
cocojoe
requested changes
Oct 2, 2019
Lock/ObserverStore.swift
Outdated
| return { controller.dismiss(animated: true, completion: completion) } | ||
| private func dismiss(from sub: UIViewController?, completion: @escaping () -> Void) -> () -> Void { | ||
| return { | ||
| //controller?.presentingViewController has to be INSIDE Queue.main.async |
Lock/ObserverStore.swift
Outdated
| private func dismiss(from controller: UIViewController?, completion: @escaping () -> Void) -> () -> Void { | ||
| guard let controller = controller else { return completion } | ||
| return { controller.dismiss(animated: true, completion: completion) } | ||
| private func dismiss(from sub: UIViewController?, completion: @escaping () -> Void) -> () -> Void { |
There was a problem hiding this comment.
Rename sub to controller please, is explicit.
There was a problem hiding this comment.
ok.. i never liked swift’s BAD engineering practice of let name = name - because it’s just plain ugly & confusing.
pixeled
changed the title
cocojoe
approved these changes
Oct 3, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
basically, controller.presentingViewController was being called/evaluated from non-main thread.
in iOS 13.1.x, they REALLY don’t like that - even if it’s just “inspection”
my app was rejected because the login view wasn’t being dismissed
this PR fixes that - basically just moves the evaluation down into the actual execution of the
Queue.mainwithout loss of functionalityFixes #565