Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sign in with Apple social login button default styling #586

Merged
merged 1 commit into from
Dec 4, 2019
Merged

Sign in with Apple social login button default styling #586

merged 1 commit into from
Dec 4, 2019

Conversation

ejensen
Copy link
Contributor

@ejensen ejensen commented Dec 3, 2019 •
edited
Loading

Changes

Adds default styling for the Sign in with Apple social login button.

Before
before
After
After

References

The styling doesn't match Apple's HIG. But it's as close as it can get given how limited Lock's current auth button styling options are.

Testing

  • This change adds unit test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@ejensen ejensen requested a review from a team December 3, 2019 20:59
@ejensen ejensen force-pushed the sign-in-with-apple-styling branch from 822c1b0 to a954b45 Compare December 3, 2019 21:01
@ejensen ejensen force-pushed the sign-in-with-apple-styling branch from a954b45 to 4d51ea3 Compare December 3, 2019 21:47
@ejensen ejensen requested a review from damieng December 4, 2019 01:15
@cocojoe cocojoe added this to the vNext milestone Dec 4, 2019
@cocojoe cocojoe self-requested a review December 4, 2019 09:42
cocojoe
cocojoe approved these changes Dec 4, 2019
View reviewed changes
Copy link
Member

@cocojoe cocojoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@cocojoe cocojoe merged commit 6f71125 into auth0:master Dec 4, 2019
@ejensen ejensen deleted the sign-in-with-apple-styling branch December 4, 2019 20:24
@Widcket Widcket mentioned this pull request Jan 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cocojoe cocojoe cocojoe approved these changes

@damieng damieng Awaiting requested review from damieng

Assignees
No one assigned
Labels
CH: Added
Projects
None yet
Milestone
2.14.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ejensen @damieng @cocojoe