Added hidden CustomTextField support #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
Thanks for the continued contribution @ejensen |
cocojoe
changed the title
Widcket
previously approved these changes
Dec 20, 2019
|
@ejensen can you please include this new feature in the README? |
ejensen
force-pushed
the
sign-up-hidden-custom-text-fields
branch
from
914b7c2 to
51afcf8
Compare
The README has been updated to include references to the new parameter. |
…and autocapitalization type
ejensen
force-pushed
the
sign-up-hidden-custom-text-fields
branch
from
51afcf8 to
f0febcd
Compare
Widcket
approved these changes
Jan 3, 2020
|
@ejensen thanks for your PR! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup from PR #570. These changes are intended to provide a way to pass through user metadata during account creation. In contrast to the key/values map approach in PR #570, this PR creates hidden UI fields that have their value assigned programmatically. This is based on the conclusion in this comment. Creating
UIViewsthat is never intended to be shown is inefficient. But is required to use the existing array ofCustomSignupFields& not breaking the interface & not needing to refactor all the code that depends onInputFieldviews being created for each of the values in thecustomSignupFieldsarray.Changes
CustomTextFieldto hiddenCustomTextFieldvalue (required to passthrough values in hidden field)CustomTextFieldautocapitalization typeCustomTextFieldautocorrection typeReferences
CustomTextFieldtype with the addition of making it hiddenTesting
Checklist