Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made email/domain match case-insensitive #594

Merged
merged 2 commits into from
Jan 23, 2020
Merged

Made email/domain match case-insensitive #594

merged 2 commits into from
Jan 23, 2020

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Jan 23, 2020

Changes

  • The user email is now matched case-insensitively against the enterprise connection domain, like in Lock.Android.
  • Fixed whitespace warnings.

References

Testing

  • This change adds unit test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@Widcket Widcket requested a review from a team January 23, 2020 17:40
@Widcket Widcket added this to the vNext milestone Jan 23, 2020
@Widcket Widcket merged commit 0635180 into master Jan 23, 2020
@Widcket Widcket deleted the fix/case-insensitive-domain-match branch January 23, 2020 19:18
@Widcket Widcket mentioned this pull request Feb 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshcanhelp joshcanhelp joshcanhelp approved these changes

Assignees
No one assigned
Labels
CH: Fixed review:small Small review
Projects
None yet
Milestone
2.15.0
Development

Successfully merging this pull request may close these issues.

EnterpriseDomainInteractor match(domain:) case insensitively
2 participants
@Widcket @joshcanhelp