Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed auth button highlighted color issue #611

Merged
merged 3 commits into from
Apr 22, 2020
Merged

Fixed auth button highlighted color issue #611

merged 3 commits into from
Apr 22, 2020

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Apr 20, 2020 •
edited
Loading

Changes

  • This PR fixes an issue that prevented custom highlighted colors from working as intended. The custom color was always darkened by 30%, which violates the POLA, as the developer would expect a color set explicitly to be used as-is.
  • The SIWA highlighted color button was set to be 30% lighter than the background color, which is black.

Screen Cast 2020-04-20 at 6 26 34 PM

Testing

  • This change adds unit test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@Widcket Widcket added this to the vNext milestone Apr 20, 2020
@Widcket Widcket requested a review from a team April 20, 2020 21:45
@Widcket Widcket changed the title Fix auth button highlighted color issue Fixed auth button highlighted color issue Apr 20, 2020
@Widcket Widcket merged commit 35baf69 into master Apr 22, 2020
@Widcket Widcket deleted the fix/highlighted-color branch April 22, 2020 15:19
@Widcket Widcket mentioned this pull request Apr 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevehobbsdev stevehobbsdev stevehobbsdev approved these changes

Assignees
No one assigned
Labels
CH: Fixed review:small Small review
Projects
None yet
Milestone
2.17.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Widcket @stevehobbsdev