Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Usability and Readability #618

Merged
merged 8 commits into from
Jul 6, 2020
Merged

Improved Usability and Readability #618

merged 8 commits into from
Jul 6, 2020

Conversation

horsejockey
Copy link
Contributor

Changes

Increase to the font size of the BannerMessageView from 11 point to 18 point as well as making the top and bottom margin equal. A font size of 11 points is too small to be easily readable by many users and the error message box was easy to miss at the top of the screen. The increase in font size and overall size helps draw attention to the messages which are often quite important to help guide a user.

Allowing users to specify a selectedTabTextColor to help emphasize to the user which tab they are currently on.

IMG_1734
IMG_1735

References

#617

Testing

The added style entry has been added to the style spec.

Checklist

@horsejockey horsejockey requested a review from a team May 26, 2020 22:56
@Widcket Widcket added the needs investigation An issue that has more questions to answer or otherwise needs work to fully understand the issue label May 26, 2020
@lbalmaceda
Copy link
Contributor

@horsejockey Thanks for your contribution 🙇 I'm not sure the close button is supposed to be covered by the toast.

@Widcket if this is a fix we require, it would first need to pass through our designer for approval.

@horsejockey
Copy link
Contributor Author

horsejockey commented May 27, 2020

@lbalmaceda I double checked and this update didn't change that behavior. It covers the close button in the current version. The toast is taller now but it starts at the same place.

Here is the original design with smaller font and same font color for selected/unselected tabs.

IMG_1748

Copy link
Contributor

@lbalmaceda lbalmaceda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good @Widcket. Please add a screenshot showing the final changes.

@Widcket
Copy link
Contributor

Widcket commented Jul 6, 2020

The original PR was modified after feedback from our designer. The final changes look like this:

Simulator Screen Shot - iPhone 11 - 2020-07-02 at 20 32 59

Simulator Screen Shot - iPhone 11 - 2020-07-02 at 20 33 03

Simulator Screen Shot - iPhone 11 - 2020-07-02 at 20 40 02

@Widcket Widcket merged commit dc4082b into auth0:master Jul 6, 2020
@Widcket
Copy link
Contributor

Widcket commented Jul 6, 2020

Thanks @horsejockey and apologies for the delay.

@Widcket Widcket added CH: Changed and removed needs investigation An issue that has more questions to answer or otherwise needs work to fully understand the issue labels Jul 6, 2020
@Widcket Widcket added this to the vNext milestone Jul 6, 2020
@Widcket Widcket linked an issue Jul 6, 2020 that may be closed by this pull request
@Widcket Widcket mentioned this pull request Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Login/Sign Up Readability and Usability
3 participants