-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved Usability and Readability #618
Conversation
Message is much too small to be easily readable and grab users attention.
@horsejockey Thanks for your contribution 🙇 I'm not sure the close button is supposed to be covered by the toast. @Widcket if this is a fix we require, it would first need to pass through our designer for approval. |
@lbalmaceda I double checked and this update didn't change that behavior. It covers the close button in the current version. The toast is taller now but it starts at the same place. Here is the original design with smaller font and same font color for selected/unselected tabs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good @Widcket. Please add a screenshot showing the final changes.
Thanks @horsejockey and apologies for the delay. |
Changes
Increase to the font size of the
BannerMessageView
from 11 point to 18 point as well as making the top and bottom margin equal. A font size of 11 points is too small to be easily readable by many users and the error message box was easy to miss at the top of the screen. The increase in font size and overall size helps draw attention to the messages which are often quite important to help guide a user.Allowing users to specify a
selectedTabTextColor
to help emphasize to the user which tab they are currently on.References
#617
Testing
The added style entry has been added to the style spec.
Checklist