Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated 37 Signals icon and display name [SDK-1945] #633

Merged
merged 1 commit into from
Sep 14, 2020
Merged

Updated 37 Signals icon and display name [SDK-1945] #633

merged 1 commit into from
Sep 14, 2020

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Sep 12, 2020

Changes

This PR updates the 37 Signals icon and changes its display name to "Basecamp".

Before

Simulator Screen Shot - iPhone 11 Pro - 2020-09-12 at 04 31 47

After

IMG_941EAC0F7927-1

Testing

  • This change adds unit test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@Widcket Widcket added CH: Changed tiny Tiny review labels Sep 12, 2020
@Widcket Widcket requested a review from a team September 12, 2020 07:39
@Widcket Widcket added this to the vNext milestone Sep 12, 2020
stevehobbsdev
stevehobbsdev approved these changes Sep 14, 2020
View reviewed changes
Copy link

@stevehobbsdev stevehobbsdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Widcket Widcket merged commit 8c8ae6e into master Sep 14, 2020
@Widcket Widcket deleted the fix/basecamp-icon branch September 14, 2020 13:15
@Widcket Widcket mentioned this pull request Oct 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevehobbsdev stevehobbsdev stevehobbsdev approved these changes

@robinbijlani robinbijlani robinbijlani approved these changes

Assignees
No one assigned
Labels
CH: Changed tiny Tiny review
Projects
None yet
Milestone
2.19.1
Development

Successfully merging this pull request may close these issues.
3 participants
@Widcket @stevehobbsdev @robinbijlani