Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increased tappable surface of close and back buttons #635

Merged
merged 3 commits into from
Oct 5, 2020
Merged

Increased tappable surface of close and back buttons #635

merged 3 commits into from
Oct 5, 2020

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Sep 25, 2020 •
edited
Loading

Changes

This PR increases the tappable surface of the close and back buttons 10pt vertically and 10pt horizontally.

References

Fixes #634

Testing

This change has been tested manually.

  • This change adds unit test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@Widcket Widcket added CH: Fixed tiny Tiny review labels Sep 25, 2020
@Widcket Widcket added this to the vNext milestone Sep 25, 2020
@Widcket Widcket requested a review from a team September 25, 2020 20:17
@Widcket Widcket changed the title Increase close button tappable surface Increased tappable surface of close button Sep 25, 2020
stevehobbsdev
stevehobbsdev previously approved these changes Sep 28, 2020
View reviewed changes
@Widcket Widcket merged commit 0a299e5 into master Oct 5, 2020
@Widcket Widcket deleted the fix/close-button branch October 5, 2020 21:21
@Widcket Widcket changed the title Increased tappable surface of close button Increased tappable surface of close and back buttons Oct 5, 2020
@Widcket Widcket mentioned this pull request Oct 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbalmaceda lbalmaceda lbalmaceda approved these changes

@stevehobbsdev stevehobbsdev stevehobbsdev left review comments

Assignees
No one assigned
Labels
CH: Fixed tiny Tiny review
Projects
None yet
Milestone
2.19.1
Development

Successfully merging this pull request may close these issues.

Back button has small tappable area
3 participants
@Widcket @stevehobbsdev @lbalmaceda