Updated Quick and Nimble #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Widcket
commented
Oct 20, 2020
| return false | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
This was producing a warning, as CredentialAuthError already implements Equatable in the library code. See https://github.com/auth0/Lock.swift/blob/master/Lock/CredentialAuthError.swift#L74
|
@cocojoe can you please update the branch protection settings? The only CircleCI job that should be marked as required is build-and-test-swift-5_2 as the others have been removed. |
cocojoe
requested changes
Oct 20, 2020
cocojoe
approved these changes
Oct 22, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR updates the test dependencies Quick and Nimble to the latest majors, making it possible to test Lock.swift with Xcode 12.
The new majors of Quick and Nimble no longer support Swift versions < 5.2. This means that the tests can no longer be run on Xcode versions < 11.4. The CircleCI config has been updated accordingly.
The requirements section in the README has been updated as well.
Testing
Checklist