Add compatibility cookie for SameSite, with option to turn it off #1232
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
#1229 introduced a change that set
sameSite
tonone
when using HTTPS. This can cause problems for older user agents that don't support this. This PR introduces a compatibility cookie wheresecure
is set andsameSite
is left blank, much like Auth0 Server behaviour as well as in Auth0 SPA SDK.See https://www.chromium.org/updates/same-site/incompatible-clients for information on which browsers are affected.
In addition, a new configuration option
legacySameSiteCookie
is introduced to control this behaviour. It defaults totrue
when not configured, which enables the legacy SameSite cookie behaviour. SettinglegacySameSiteCookie
tofalse
disables this behaviour.References
#1229
Testing
Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.
Checklist