Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to enable autocomplete for username/email inputs #987

Closed
maxlapides opened this issue Apr 27, 2017 · 4 comments
Closed

Add option to enable autocomplete for username/email inputs #987

maxlapides opened this issue Apr 27, 2017 · 4 comments
Assignees

Comments

@maxlapides
Copy link

I've received a number of questions from our users on why the login page isn't autocompleting their username like it used to (before we upgraded Lock). After taking a look, I discovered that the autocomplete attribute is set to off on the username field. I did some digging and traced it back to this commit: 70c0b0e

I'm not sure why autocomplete was disabled. Is there a reason for this? If not, can we switch autocomplete back on? Thanks!

@luisrudge
Copy link
Contributor

We might consider an option to enable autocomplete for the username/email field. Does that work for you?

@maxlapides
Copy link
Author

maxlapides commented Apr 27, 2017 via email

@luisrudge
Copy link
Contributor

I think it broke some styles or validations when we were migrating to v9 to v10. I wasn't here, so I'm not sure.

@luisrudge luisrudge self-assigned this Apr 27, 2017
@luisrudge luisrudge changed the title Autocomplete is disabled Add option to enable autocomplete for username/email inputs Apr 27, 2017
@luisrudge
Copy link
Contributor

fixed in #1022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants