Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update es.js #1209

Merged
merged 3 commits into from
Feb 22, 2018
Merged

Update es.js #1209

merged 3 commits into from
Feb 22, 2018

Conversation

Paulahur
Copy link
Contributor

Small changes to provide better information for the users.

Small changes to provide better information for the users.
@luisrudge
Copy link
Contributor

Thanks for the PR @PaulaRDi18n 🎉 I asked someone that speaks spanish to review this later.

I'm from Florianopolis myself and I couldn't help but notice that you work at resultados digitais. ISs RD using Auth0 for the CMS or something else? Thanks!

@luisrudge
Copy link
Contributor

Oh, I just found RDStation's login page and you're using lock. That's amazing! In any case, you should note that when this PR gets merged and released, it will only be available for 11.x versions, and not for 10.x versions. As of today, you're using 10.x:
image

We recently released a new major version with improved security and features and did our best to not introduce any breaking changes. If you need help upgrading, just get in touch via github or ping me directly: [email protected]

Copy link
Contributor

@lbalmaceda lbalmaceda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! 🎉 I left you a few comments

src/i18n/es.js Outdated
too_many_attempts:
'Su cuenta ha sido bloqueada luego de múltiples intentos de inicio de sesión consecutivos.',
'lock.mfa_registration_required':
'Por favor enrole su dispositivo antes de continuar con el segundo factor.',
'Se requiere autenticación multifactor pero su dispositivo no está registrado. Por favor inscríbalo antes de continuar.',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say Se requiere autenticación de dos factores. Por favor registre su dispositivo antes de continuar.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense

src/i18n/es.js Outdated
@@ -62,7 +62,7 @@ export default {
forgotPasswordTitle: 'Restablecer contraseña',
forgotPasswordAction: '¿Olvidó su contraseña?',
forgotPasswordInstructions:
'Por favor ingrese su dirección de correo. Le enviaremos las instrucciones para restablecer su contrseña.',
'Por favor escriba su dirección de correo. Le enviaremos las instrucciones para restablecer su contrseña.',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ingrese is used in the rest of the sentences of this same file. I would keep it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants