Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test cases to check captcha credential #4356

Merged
merged 7 commits into from
Jun 19, 2024
Merged

Add test cases to check captcha credential #4356

merged 7 commits into from
Jun 19, 2024

Conversation

pkong-ds
Copy link
Contributor

@pkong-ds pkong-ds commented Jun 18, 2024 •
edited
Loading

@pkong-ds pkong-ds changed the title [DEPS: 4355] Add test cases to check captcha credential [DEPS: #4355] Add test cases to check captcha credential Jun 18, 2024
@tung2744 tung2744 mentioned this pull request Jun 18, 2024
Closed
@louischan-oursky louischan-oursky self-requested a review June 18, 2024 11:24
@louischan-oursky louischan-oursky self-assigned this Jun 18, 2024
louischan-oursky
louischan-oursky reviewed Jun 18, 2024
View reviewed changes
Copy link
Collaborator

@louischan-oursky louischan-oursky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Check uniqueness of alias. (Refer to OAuth provider)
  • Check secret type-specific fields.
  • Add a test case: Both legacy and new configuration are present

@pkong-ds pkong-ds changed the title [DEPS: #4355] Add test cases to check captcha credential Add test cases to check captcha credential Jun 18, 2024
@pkong-ds pkong-ds force-pushed the 1411-fix-deprecated-captcha-credential branch from 59aface to 964261d Compare June 18, 2024 13:33
@louischan-oursky louischan-oursky force-pushed the 1411-fix-deprecated-captcha-credential branch from 964261d to c47cbb3 Compare June 18, 2024 17:09
@louischan-oursky louischan-oursky self-requested a review June 19, 2024 02:10
@louischan-oursky louischan-oursky merged commit ed2c5d5 into authgear:main Jun 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louischan-oursky louischan-oursky louischan-oursky approved these changes

Assignees

@louischan-oursky louischan-oursky

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pkong-ds @louischan-oursky @tung2744