Support inline preview in auth flow v2 #4359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can have a look at this PR if you have time. Please give feedback on what do you think. |
tung2744
reviewed
Jun 19, 2024
cychiuae
force-pushed
the
dev-1424-support-authui-preview-mode
branch
from
8f2e377 to
d99f721
Compare
cychiuae
force-pushed
the
dev-1424-support-authui-preview-mode
branch
from
f9f7652 to
e506ece
Compare
cychiuae
changed the title
|
@tung2744 Can review now |
tung2744
reviewed
Jun 20, 2024
tung2744
reviewed
Jun 20, 2024
tung2744
reviewed
Jun 20, 2024
cychiuae
force-pushed
the
dev-1424-support-authui-preview-mode
branch
from
5b8e399 to
b1c9177
Compare
cychiuae
commented
Jun 23, 2024
louischan-oursky
approved these changes
Jun 24, 2024
|
@cychiuae https://github.com/authgear/authgear-server/actions/runs/9632178601/job/26580940503?pr=4359 Please resolve the lint errors. |
|
@louischan-oursky @tung2744 Updated. THanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.