Fixing a bug in merging token id and user info data. 0 is being omitted. #1220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would rather keep the claims merging as they are now (messy). There is a merge request pending, which aims to fix that. I am planning to fix this in the upcoming major next release. See #881. Can you verify if the new code would work for you? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1220 +/- ##
=======================================
Coverage 77.92% 77.92%
=======================================
Files 45 45
Lines 1726 1726
Branches 346 346
=======================================
Hits 1345 1345
Misses 342 342
Partials 39 39
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
|
I now looked at the patch, maybe its still worth to merge this, as it should not change the existing behavior and only fix a edge case... |
pamapa
approved these changes
Oct 27, 2023
|
Thank you! Hope to help more! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solution is created based on a bug in merging two claim services.
In more details, the first implementation, whenever a user have a user attribute in the first claim and the second claim, if this attribute has a value of 0, it will be omitted: "!previousValue" line 73 in src/ClaimService.ts, however the expected output should contain that 0. In the solution provided, this previous value is being checked if it is undefined.
Checklist