Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove now useless useCallback on signoutSilent #1063

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

pamapa
Copy link
Member

@pamapa pamapa commented Dec 18, 2023

Closes/fixes #issue

Checklist

  • This PR makes changes to the public API
  • I have included links for closing relevant issue numbers

@pamapa pamapa added this to the 3.0.0-rc.0 milestone Dec 18, 2023
Copy link

codecov bot commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (540d1c7) 81.45% compared to head (4368f46) 81.14%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1063      +/-   ##
==========================================
- Coverage   81.45%   81.14%   -0.31%     
==========================================
  Files           9        9              
  Lines         124      122       -2     
  Branches       20       20              
==========================================
- Hits          101       99       -2     
  Misses         16       16              
  Partials        7        7              
Flag Coverage Δ
unittests 81.14% <ø> (-0.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pamapa pamapa merged commit 6a70078 into main Dec 18, 2023
4 checks passed
@pamapa pamapa deleted the remove-useless-use-callback branch December 18, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant