Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bulk check typing issue #189

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

tstirrat15
Copy link
Contributor

Fixes #187

Note

This is not yet a solution to the problem, but it is a test that demonstrates the problem.

Description

As seen in #187, promisified clients have the wrong types, which means that they disagree with the runtime about the correct invocation. This is likely in part due to how we're typing the promisified clients, and in part due to the clients having multiple overloads for the generated methods.

Changes

  • Add some test utilities
  • Add a test that demonstrates the issue

Testing

Review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

typing issue with custom grpc callOptions on single operation
1 participant