-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update deps, adopt v1 api #30
Conversation
a86423a
to
c983ee5
Compare
c983ee5
to
5b19033
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a flag bikeshed:
--proxy-addr string address to listen on to serve proxy (default ":9090")
--proxy-enabled enable proxy http server (default true)
--proxy-cors-allowed-origins strings allowed origins for CORS requests (default [*])
--proxy-tls-cert-path string local path to the TLS certificate used to serve proxy
--proxy-tls-key-path string local path to the TLS key used to serve proxy
--proxy-check-permission string permission to check
--proxy-check-resource-id-query-param string query parameter used as the Object ID to check
--proxy-check-resource-type string resource type to check
--proxy-check-subject-relation string optional subject relation to check
--proxy-check-subject-type string subject type to check
--proxy-spicedb-endpoint string address of the Authzed to use for checking (default "grpc.authzed.com:443")
--proxy-spicedb-insecure connect to Authzed without TLS
--proxy-spicedb-tls-cert-path string path at which to find a certificate for authzed TLS
--proxy-spicedb-token string authzed token to use for checking tenancy
--proxy-upstream-prometheus-addr string address of the upstream Prometheus
do we want the proxy
prefix on the flags in the second block? they make sense to me on the first block (configuring the proxy endpoint itself, distinguishing it from the metrics endpoint) but the rest just seem like config for the whole program
I treated the whole system as "proxy" in case at some point this program ends up running multiple types of servers. That's how we've done things with SpiceDB, so that it's a bit less confusing. |
c85e010
to
c47d7d5
Compare
fb2e68d
to
f72cc1e
Compare
f72cc1e
to
bb2ff78
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.