Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update deps, adopt v1 api #30

Merged
merged 5 commits into from
Feb 18, 2022
Merged

update deps, adopt v1 api #30

merged 5 commits into from
Feb 18, 2022

Conversation

jzelinskie
Copy link
Member

No description provided.

@jzelinskie jzelinskie requested a review from ecordell January 7, 2022 23:41
@github-actions github-actions bot added the area/dependencies Affects dependencies label Jan 7, 2022
@jzelinskie jzelinskie force-pushed the deps-rewrite branch 8 times, most recently from a86423a to c983ee5 Compare January 10, 2022 18:15
@samkim samkim marked this pull request as ready for review January 11, 2022 16:11
Copy link
Contributor

@ecordell ecordell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a flag bikeshed:

      --proxy-addr string                            address to listen on to serve proxy (default ":9090")
      --proxy-enabled                                enable proxy http server (default true)
      --proxy-cors-allowed-origins strings           allowed origins for CORS requests (default [*])
      --proxy-tls-cert-path string                   local path to the TLS certificate used to serve proxy
      --proxy-tls-key-path string                    local path to the TLS key used to serve proxy


      --proxy-check-permission string                permission to check
      --proxy-check-resource-id-query-param string   query parameter used as the Object ID to check
      --proxy-check-resource-type string             resource type to check
      --proxy-check-subject-relation string          optional subject relation to check
      --proxy-check-subject-type string              subject type to check
      --proxy-spicedb-endpoint string                address of the Authzed to use for checking (default "grpc.authzed.com:443")
      --proxy-spicedb-insecure                       connect to Authzed without TLS
      --proxy-spicedb-tls-cert-path string           path at which to find a certificate for authzed TLS
      --proxy-spicedb-token string                   authzed token to use for checking tenancy
      --proxy-upstream-prometheus-addr string        address of the upstream Prometheus

do we want the proxy prefix on the flags in the second block? they make sense to me on the first block (configuring the proxy endpoint itself, distinguishing it from the metrics endpoint) but the rest just seem like config for the whole program

go.mod Outdated Show resolved Hide resolved
main.go Show resolved Hide resolved
@github-actions github-actions bot added the area/tooling Affects the dev or user toolchain label Feb 17, 2022
@jzelinskie
Copy link
Member Author

I treated the whole system as "proxy" in case at some point this program ends up running multiple types of servers. That's how we've done things with SpiceDB, so that it's a bit less confusing.

@github-actions github-actions bot added the area/docs Affects docs or metadata (e.g. README) label Feb 17, 2022
README.md Outdated Show resolved Hide resolved
main_test.go Show resolved Hide resolved
@jzelinskie jzelinskie force-pushed the deps-rewrite branch 2 times, most recently from fb2e68d to f72cc1e Compare February 17, 2022 22:43
main.go Outdated Show resolved Hide resolved
Copy link
Contributor

@ecordell ecordell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ecordell ecordell merged commit d62dadf into main Feb 18, 2022
@ecordell ecordell deleted the deps-rewrite branch February 18, 2022 23:48
@github-actions github-actions bot locked and limited conversation to collaborators Feb 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/dependencies Affects dependencies area/docs Affects docs or metadata (e.g. README) area/tooling Affects the dev or user toolchain
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants