datasore: test that all datastores serialize revisions compatible wit…

…h dispatch

pkg/datastore/test/datastore.go

@@ -50,6 +50,7 @@ func All(t *testing.T, tester DatastoreTester) {
 	t.Run("TestConcurrentWriteSerialization", func(t *testing.T) { ConcurrentWriteSerializationTest(t, tester) })
 
 	t.Run("TestRevisionQuantization", func(t *testing.T) { RevisionQuantizationTest(t, tester) })
+	t.Run("TestRevisionSerialization", func(t *testing.T) { RevisionSerializationTest(t, tester) })
 
 	t.Run("TestWatch", func(t *testing.T) { WatchTest(t, tester) })
 	t.Run("TestWatchCancel", func(t *testing.T) { WatchCancelTest(t, tester) })

pkg/datastore/test/revisions.go

@@ -11,6 +11,7 @@ import (
 	"github.com/authzed/spicedb/internal/datastore/common"
 	"github.com/authzed/spicedb/pkg/datastore"
 	core "github.com/authzed/spicedb/pkg/proto/core/v1"
+	dispatch "github.com/authzed/spicedb/pkg/proto/dispatch/v1"
 )
 
 // RevisionQuantizationTest tests whether or not the requirements for revisions hold
@@ -65,3 +66,25 @@ func RevisionQuantizationTest(t *testing.T, tester DatastoreTester) {
 		})
 	}
 }
+
+// RevisionSerializationTest tests whether the revisions generated by this datastore can
+// be serialized and sent through the dispatch layer.
+func RevisionSerializationTest(t *testing.T, tester DatastoreTester) {
+	require := require.New(t)
+
+	ds, err := tester.New(0, veryLargeGCWindow, 1)
+	require.NoError(err)
+
+	ctx, cancel := context.WithTimeout(context.Background(), 1*time.Second)
+	defer cancel()
+	revToTest, err := ds.ReadWriteTx(ctx, func(ctx context.Context, rwt datastore.ReadWriteTransaction) error {
+		return rwt.WriteNamespaces(testNamespace)
+	})
+	require.NoError(err)
+
+	meta := dispatch.ResolverMeta{
+		AtRevision:     revToTest.String(),
+		DepthRemaining: 50,
+	}
+	require.NoError(meta.Validate())
+}